search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Studio tree highlighting clears when toggling Featured/All elements #272

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

https://github.com/phetsims/studio/issues/214 has reappeared. At 4/22/21 phet-io meeting, @kathy-phet said that she would like that evaluated for inclusion in the 1.3 release.

Assigning to @zepumph @samreid to inform me when it has been fixed, and how to patch the 1.3 branch.

UPDATE from @zepumph: changed the link.

arouinfar commented 3 years ago

@pixelzoom I verified the fix in https://github.com/phetsims/studio/issues/214, here's the commit to cherry-pick:

https://github.com/phetsims/studio/commit/c6f4728e6a5ef6b69640c9152090a910788a0fd9

pixelzoom commented 3 years ago

No one has summarized what the final behavior is, and I'm not going to spend the time trying to figure that out by reading through https://github.com/phetsims/studio/issues/214. I'm going to assume that what @samreid described in https://github.com/phetsims/studio/issues/214#issuecomment-825906062, and the commit message associate with phetsims/studio@c6f4728, describes is what you decided to do. I'd prefer to test myself. But I'm just going to patch Natural Selection 1.3 with the recommended sha, and assume that all is well, and leave it for QA to verify.

Note to self: Need to create and patch a new studio branch, "natural-selection-1.3".

pixelzoom commented 3 years ago

I created a new studio branch (natural-selection-1.3) and patched in phetsims/studio@c6f4728.

I still have some questions about how this is supposed to behave, see https://github.com/phetsims/studio/issues/214#issuecomment-826984877. On hold until those questions are answered.

pixelzoom commented 3 years ago

My questions were answered in phetsims/studio#214, and this seems to be behaving as designed. So ready for QA.

To verify:

  1. Start Natural Selection in Studio.
  2. Set "PhET-iO Elements" to "All".
  3. Select naturalSelection.introScreen.model.simulationModeProperty in the Studio Tree.
  4. Set "PhET-iO Elements" to "Featured".
  5. Verify that naturalSelection.introScreen.model becomes selected in the Studio Tree.
  6. Set "PhET-iO Elements" to "All".
  7. Verify that naturalSelection.introScreen.model remains selected in the Studio Tree.
KatieWoe commented 3 years ago

Verified on Win 10 Chrome in rc.2

liammulh commented 3 years ago

Also seems to be working on macOS 11 + Chrome.

liammulh commented 3 years ago

Also seems to be working on macOS 11 + Safari.

KatieWoe commented 3 years ago

And Win 10 Firefox, closing