search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Diff wrapper is rendering parametric types as badly formed HTML #276

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

https://github.com/phetsims/phet-io-wrappers/issues/407 needs to be patched into the next RC.

In https://github.com/phetsims/phet-io-wrappers/issues/407#issue-869051499, @samreid identified this issues as blocking.

pixelzoom commented 3 years ago

From https://github.com/phetsims/phet-io-wrappers/issues/407#issuecomment-827774876, a fix is ready for cherry-picking. The commit is https://github.com/phetsims/phet-io-wrappers/commit/94dcc1aac0381127fa3028aac59a7842f6c5df2e. I'm guessing that I should cherry-pick this after https://github.com/phetsims/natural-selection/issues/271, to avoid problems. So on hold until https://github.com/phetsims/natural-selection/issues/271 is resolved.

pixelzoom commented 3 years ago

Consolidating this issue into https://github.com/phetsims/natural-selection/issues/271