phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Mutation Coming disabled if Add Mutation button is hidden #287

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

Device Dell OS Win Browser Chrome Problem Description For https://github.com/phetsims/QA/issues/662. Feel free to close if this is intended behavior, but it seemed odd to me. In Studio, if you add a mutation, but it hasn't appeared, and then you hide that mutation button (such as with naturalSelection.labScreen.view.addMutationsPanel.teethRow.visibleProperty) the mutation is canceled and isn't added in the next generation. This doesn't seem to cause a problem in the mutation is already introduced. Visuals goesawaywhenhidden

amanda-phet commented 3 years ago

Is this a bug? It seems like a strange use of studio, to me. But I'll let @pixelzoom take a look and decide if it's worth fixing.

KatieWoe commented 3 years ago

Not sure if it is a bug, feel free to remove if not. I did also notice that hiding the gene didn't seem to remove the line from the graph. You would have to disable that line first, then hide the gene.

stillingraph
KatieWoe commented 3 years ago

If you hide the whole panel, this visual oddity happens.

maybemoreodd
pixelzoom commented 3 years ago

As @amanda-phet said, this is a strange use of Studio. It's also not a supported use of this feature - you can't schedule a mutation to occur, hide the mutation, and expect what you scheduled to be cancelled. Showing/hiding a mutation (or the Add Mutation panel) is something that is configured for the screen, and there's no pedagogical reason to change it after configuration. So... Closing as "won't fix".