search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Long screen names push navigation bar icon to the right when sim is launched #295

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

For https://github.com/phetsims/QA/issues/662. https://github.com/phetsims/joist/issues/725 is a problem in the natural-selection 1.4 branch. Blocking because it impacts usability of the navigation bar.

pixelzoom commented 3 years ago

Assigning to @jonathanolson, because he's responsible for the blocking issue https://github.com/phetsims/joist/issues/725. Please let me know when this is fixed, and what I need to patch.

pixelzoom commented 3 years ago

From https://github.com/phetsims/joist/issues/725#issuecomment-879274934, the commits to cherry-pick (in this order) are:

https://github.com/phetsims/joist/commit/321e7888eb9feb56133d98f6d35db079678fc7bb https://github.com/phetsims/joist/commit/58fd74142ca8144982ecc13df4abeab6fa946280 https://github.com/phetsims/joist/commit/6299e69d256f1d997832f5b8d4f88ac50ae5ad08 https://github.com/phetsims/joist/commit/eb2a5d97cd2fe4196f5e98e84ad681c49aaf7a75 https://github.com/phetsims/joist/commit/720b149991e62d7ccfa11f1fb97fe1a3879d038f https://github.com/phetsims/joist/commit/33aab76edf4019b34a23ace105389ae787c251a3

https://github.com/phetsims/scenery/commit/f0adaceb9b2d8f0420258c1dc65bb94def77c1bd https://github.com/phetsims/scenery/commit/7656bb0fda91e7f78b8e21ddd77bd404f4568e84 https://github.com/phetsims/scenery/commit/aa0952dc985575aa52f75316b222721b9dd6206b

pixelzoom commented 3 years ago

Cherry-picked the above shas, in order, without any problems.

Tested a local build using these steps:

  1. Lauch the sim in Studio
  2. Change the value of naturalSelection.introScreen.nameProperty to "Into The Spiderverse"
  3. Press the "Preview Sim" button. Verify that the screen name looks correct in the navbar and home screen.

Ready for testing in the next RC.

KatieWoe commented 3 years ago

Looks good in rc.2