phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

ScreenView `visibleProperty` should not be featured #332

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Noticed when migrating overrides.js into code for #331.

In natural-selection-overrides.js, I see that the visibleProperty of both ScreenViews is featured:

    "naturalSelection.introScreen.view.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.view.visibleProperty": {
      "phetioFeatured": true
    }

This seems odd, because

@amanda-phet was this intentional, or is this a bug? I recommend not featuring these elements.

amanda-phet commented 1 year ago

I have no recollection of featuring this, and can't understand why it's featured (being read-only). Please un-feature!

pixelzoom commented 1 year ago

Done in the above commits. view.visibleProperty is now phetioFeatured: false for both screens.