search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

How to migrate archetype metadata from overrides.js to code? #333

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Noticed when migrating overrides.js into code for https://github.com/phetsims/natural-selection/issues/331.

There are several occurrences of "archetype" in natural-selection-overrides.js, see below. How do I migrate this into code? 

    "naturalSelection.introScreen.model.bunnyCollection.bunnyGroup.archetype.genotype.abbreviationProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.introScreen.model.bunnyCollection.bunnyGroup.archetype.phenotype": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.model.bunnyCollection.bunnyGroup.archetype.genotype.abbreviationProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.model.bunnyCollection.bunnyGroup.archetype.phenotype": {
      "phetioFeatured": true
    },
pixelzoom commented 1 year ago

In the above commit, I ignored the "archetype" and simply added phetioFeatured: true to the Properties in the dynamic classes. This seemed to work, and there were no API changes with grunt generate-phet-io-api. I can imagine that this will be confusing for other devs, and should be included in documentation changes for https://github.com/phetsims/phet-io/issues/1934.