search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Missing feature for `playButtonGroup.visibleProperty` in Lab screen #334

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Noticed when migrating overrides.js into code for https://github.com/phetsims/natural-selection/issues/331.

In natural-selection-overrides.js, I see:

    "naturalSelection.introScreen.view.environmentPanel.playButtonGroup.visibleProperty": {
      "phetioFeatured": true
    },

This is for the Intro screen. I do not see the corresponding playButtonGroup.visibleProperty for the Lab screen. This seems like a bug.

@amanda-phet should playButtonGroup.visibleProperty be featured for both screens? Or did you have a reason for featuring it only in the Intro screen?

amanda-phet commented 1 year ago

Looking at this again, I'm not sure why I featured this. I can't think of a good use-case for hiding this button. Please un-feature.

pixelzoom commented 1 year ago

Done in the above commits. playButtonGroup.visibleProperty is now phetioFeatured: false in both screens.