Closed pixelzoom closed 1 year ago
Note to self: This is now featured in code. To un-feature, go to ProportionsGraphNode.ts, and delete phetioFeatured: true
from inner class Column
.
Discussed with @pixelzoom and again, can't understand why I featured this, so we agreed it should be un-featured.
Done in the above commits. proportionsGraphNode.columns.*Column.visibleProperty
is now phetioFeatured: false
throughout.
Noticed when migrating overrides.js into code for https://github.com/phetsims/natural-selection/issues/331.
In natural-selection-overides.js:
This features the
visibleProperty
of each column in the Proportions graph:But the
visibleProperty
is alsophetioReadOnly: true
, and cannot be controlled by the user. Recall that the visibility of gene-related UI components is controlled by the Properties underview.genes
, for example:So do we really want to feature something that the user can't change? I recommend that we unfeature these elements.