phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Should `visibleProperty` of the Proportions graph columns be featured? #335

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Noticed when migrating overrides.js into code for https://github.com/phetsims/natural-selection/issues/331.

In natural-selection-overides.js:

    "naturalSelection.introScreen.view.graphs.proportionsNode.proportionsGraphNode.columns.earsColumn.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.introScreen.view.graphs.proportionsNode.proportionsGraphNode.columns.furColumn.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.introScreen.view.graphs.proportionsNode.proportionsGraphNode.columns.teethColumn.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.view.graphs.proportionsNode.proportionsGraphNode.columns.earsColumn.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.view.graphs.proportionsNode.proportionsGraphNode.columns.furColumn.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.view.graphs.proportionsNode.proportionsGraphNode.columns.teethColumn.visibleProperty": {
      "phetioFeatured": true
    },

This features the visibleProperty of each column in the Proportions graph:

screenshot_2505

But the visibleProperty is also phetioReadOnly: true, and cannot be controlled by the user. Recall that the visibility of gene-related UI components is controlled by the Properties under view.genes, for example:

screenshot_2506

So do we really want to feature something that the user can't change? I recommend that we unfeature these elements.

pixelzoom commented 1 year ago

Note to self: This is now featured in code. To un-feature, go to ProportionsGraphNode.ts, and delete phetioFeatured: true from inner class Column.

amanda-phet commented 1 year ago

Discussed with @pixelzoom and again, can't understand why I featured this, so we agreed it should be un-featured.

pixelzoom commented 1 year ago

Done in the above commits. proportionsGraphNode.columns.*Column.visibleProperty is now phetioFeatured: false throughout.