Closed arouinfar closed 1 year ago
Done in the above commits. This was an API change, and required new migration rules.
For view.graphs.pedigreeNode.allelesPanel.*Row.checkbox.visibleProperty
, I can think of no purpose to have this element if it's read-only; it will always be true. So rather than make it read-only, I unistrumented checkbox.visibleProperty
. @arouinfar let me know if you had a purpose for it, and I can certainly make it read-only.
@arouinfar please review. Close OK.
I unistrumented
checkbox.visibleProperty
.
Good call, thanks @pixelzoom. The changes all look good, closing.
For #323
@pixelzoom I've identified a few elements that should be
phetioReadOnly: true
.There is no need for the client to control these Properties:
model.bunnyCollection.deadBunnies.countsProperty
model.bunnyCollection.liveBunnies.countsProperty
model.bunnyCollection.recessiveMutants.countsProperty
model.graphs.proportionsModel.currentStartCountsProperty
view.graphs.populationNode.populationGraphNode.generationScroller.*Button.enabledProperty
In the Pedigree Graph, it's possible to hide the allele checkboxes, but leave behind the legend information, which seems odd.
view.graphs.pedigreeNode.allelesPanel.*Row.checkbox.visibleProperty