Closed arouinfar closed 1 year ago
For https://github.com/phetsims/qa/issues/967, note that 1.5.0-dev.5 was published before revising examples.md. Please contact @arouinfar for the status of examples.md. It may be ready to review in master by the time that this test is underway.
In the above commit, I removed customizations that we wouldn't recommend to clients and some simpler examples covered in the general PhET-iO Guide. I also added examples describing the query parameters. There's still quite a bit to do here, though.
I completed the examples doc in the commit above and it is ready for review by QA. I added notes in the main QA issue, pasted here for convenience:
QA, please review examples.md on master. Note that the example links containing {{STUDIO_PATH}} will only work in a built version. To test, please copy and paste the query string yourself.
For https://github.com/phetsims/qa/issues/967 @arouinfar this phetioID needs to be fixed:
Thanks @Nancy-Salpepi! Not sure how that happened, but it's been fixed in the above commit.
Cool. Shall we close this then?
Yes, let's close.
Reopening. I goofed and didn't actually format the links like links, so they are showing up like this in the built version:
Thanks @pixelzoom. Looks good to me too, closing.
For #323
The examples.md doc should be updated for the 1.5 release.
TODOs include
getStateForObject
to get bunny data.