search

phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Population checkboxes become unchecked with Reset All when using mutation/population query parameters #356

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air (m1 chip)

Operating System 13.5

Browser 16.6

Problem description For https://github.com/phetsims/qa/issues/968, if I launch the sim using the query parameters labMutations and labPopulation or introMutations and intoPopulation, the checkboxes in the Population panel are checked. Pressing Reset All unchecks the checkboxes even though the mutations are already selected. Pressing play doesn't result in them becoming checked either. This also appears in published.

Steps to reproduce

  1. Add ?labMutations=FeT&labPopulation=5FFEETT,5ffeett,5FfEeTt to the url
  2. Press Reset All --checkboxes become unchecked
  3. Press yellow Play button --checkboxes remain unchecked

Visuals

https://github.com/phetsims/natural-selection/assets/87318828/cd6215f6-8798-4dec-90d8-363c318a1cc0

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Natural Selection‬ URL: https://phet-dev.colorado.edu/html/natural-selection/1.5.0-rc.1/phet/natural-selection_all_phet.html?labMutations=FeT&labPopulation=5FFEETT,5ffeett,5FfEeTt&screens=2 Version: 1.5.0-rc.1 2023-08-03 22:56:11 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Safari/605.1.15 Language: en-US Window: 1386x712 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
Nancy-Salpepi commented 1 year ago

This also happens with the allele checkboxes. On startup, they will be checked (after selecting the Pedigree radio button), but pressing Reset All will uncheck them even though the mutations are already selected by the query parameters.

pixelzoom commented 1 year ago

Fixed in 1.5 and master for Population and Pedigree graphs.

@Nancy-Salpepi please review. If this looks OK, change the label to "fixed-awaiting-deploy" for spot-check in RC2.

Nancy-Salpepi commented 1 year ago

looks good in master.

pixelzoom commented 1 year ago

Please verify in 1.5.0-rc.2 for https://github.com/phetsims/qa/issues/971. Close this issue if it's OK.

KatieWoe commented 1 year ago

Looks good in rc.2 to me