search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

window.phet.neuron conflicts with PhET namespace convention #102

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

In neuron-main.js:

    // create a namespace for sim-specific globals
    window.phet.neuron = window.phet.neuron || {};

This conflicts with PhET's new convention for namespacing, where a subtype of phetCore.Namespace is used. See for example color-vision.colorVision.js.

jbphet commented 8 years ago

Fixed, closing.