search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

StringTest=double not handled gracefully by chart title #103

Closed ariel-phet closed 8 years ago

ariel-phet commented 8 years ago

The chart title overlaps with the clear button. The chart title should scale down in font size if it gets too long (perhaps if it is going to violate the space of the Clear button?

neuron

jbphet commented 8 years ago

Fixed in both the master and 1.0 branches by adding a maxWidth to the title and making some other adjustments. Chart for stringTest=double now looks like this:

neuron-chart-double-strings

For stringTest=long it looks as shown in the following screen capture. The Clear button is very short, but setting a min height wasn't working as expected, and the caption is ridiculously long anyway, so I don't believe that this will be a problem in the real world.

neuron-chart-long-strings

jbphet commented 8 years ago

Fix should appear in v1.0.0-rc.2, leaving open until verified on that release.

jbphet commented 8 years ago

Assigning to @ariel-phet so that he or someone on the QA team can verify that this is fixed on v1.0.0-rc.2 (http://www.colorado.edu/physics/phet/dev/html/neuron/1.0.0-rc.2/neuron_en.html).

ariel-phet commented 8 years ago

Made checklist item for https://github.com/phetsims/tasks/issues/485

elisemorgan commented 8 years ago

This issue has been resolved