search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Neuron patches for scenery #120

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

@jbphet neuron needs to be patched from two scenery issues:

Canvas renderer not properly set on Edge for navbar/menu/homescreen phetsims/scenery/issues/515 (This is the main fix for phetsims/joist/issues/321)

Text boundsMethod 'fast' should still allow Canvas rendering (but prevent fitting) phetsims/scenery/issues/516 which fixes the concentration layout: neuron

jbphet commented 8 years ago

@jonathanolson and I discussed this and decided that instead of trying to patch Scenery so that bounds method values of 'fast' still allowed canvas, I would just try turning off that bounds method and using the default and qualify the performance on iPad to see if it reduced significantly. I ran three trials with and without this flag set, measured the results using the neuronProfiler=1 flag, and found no performance degradation. I'll remove the flag and move forward with the next RC.

phet-steele commented 8 years ago

@jbphet reported as successfully fixed.

jbphet commented 8 years ago

Patches and code changes complete, closing.