search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

lint errors #130

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

After adding eslint rules related to switch statements (https://github.com/phetsims/chipper/issues/485), this sim is failing lint.

% grunt lint
Running "eslint:repoFiles" (eslint) task

/Users/cmalley/PhET/GitHub/neuron/js/neuron/model/SodiumDualGatedChannel.js
  105:7  error  Expected a default case  default-case

/Users/cmalley/PhET/GitHub/neuron/js/neuron/view/ParticlesCanvasNode.js
  115:9  error  Expected a default case  default-case

✖ 2 problems (2 errors, 0 warnings)

Warning: Task "eslint:repoFiles" failed. Use --force to continue.

Aborted due to warnings.
pixelzoom commented 8 years ago

Errors fixed, @jbphet please review.

jbphet commented 8 years ago

Changes look good, and I test the sim (with the webgl=false flag to make sure the particle canvas was tested) and it runs fine. Closing.