search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

recording starts running immediately instead of waiting for stimulus #136

Closed jbphet closed 7 years ago

jbphet commented 7 years ago

On the current master version, the recording appears to start right away instead of waiting until the user pushes the "Stimulate Neuron" button.

My guess is that this was introduced when this sim was moved off of Property Set, see https://github.com/phetsims/axon/issues/102.

Assigning to @Denz1994, since he did the conversion.

Denz1994 commented 7 years ago

After talking with @jbphet on this issue, I figured out what property was not being set.

Essentially, it was modeProperty.get(mode) when it should have been modeProperty.set(mode). Thank you for the summary of how the sim should behave with by reviewing the published version.