incorrect inherit call in MembranePotentialChart.js

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 3 forks source link

incorrect inherit call in MembranePotentialChart.js #145

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

Noted while working on https://github.com/phetsims/tasks/issues/1049.

In the MembranePotentialChart.js, Node superclass constructor is call, but inherit is using Panel. Node appears to be the proper superclass.

function MembranePotentialChart( chartDimension, neuronClockModelAdapter ) {

  const self = this;
  Node.call( this );
...
}
...
inherit( Panel, MembranePotentialChart, {

pixelzoom commented 4 years ago

Fixed in the above commit. @jbphet please review.

jbphet commented 4 years ago

Looks good to me, thanks. Closing.