Shading is incorrect on step back button

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 3 forks source link

Shading is incorrect on step back button #20

Closed jbphet closed 9 years ago

jbphet commented 9 years ago

The positions of the shadow and the highlight for the step back button appear to be reversed from that of the play/pause and step forward buttons. My guess is that the step forward button was just rotated 180 degrees for this, which is clever, but the resulting look is odd. This should be corrected so that the highlights and shadows are consistent. See screenshot below.

neuron-buttons

AshrafSharf commented 9 years ago

A separate StepBackButton class is created to fix the shading issue. Have attached the screenshot of the new button below

samreid commented 9 years ago

Excellent work, looks great. I'll also move it to scenery-phet.

jbphet commented 9 years ago

Looks great, closing. Thanks to @samreid for moving it to common code.