search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Overlapping nodes when using longer strings #3

Closed samreid closed 9 years ago

samreid commented 9 years ago

I hacked string.js to double the strings like so: onload( parsedStrings[key]+':'+parsedStrings[key] );

And the sim looks like this: image

The fast forward radio button covers up the rewind button. And the chart makes it difficult to access the chart checkbox (for hiding the chart). Perhaps we need another way to close the chart, and the speed radio buttons should be layed out so they do not overlap the rewind button.

Discovered during review #1

AshrafSharf commented 9 years ago

The speed and legend panels are left and right aligned with a padding value (20). The chart now has a close button - (Implemented as part of issue #4) The chart control expands on lengthy strings - do we have to manage this? If yes, @samreid could you please suggest what should be the strategy (multi-line wrapping,tool-tip,ellipses etc)

samreid commented 9 years ago

Here is the new screenshot:

image

it looks like there is a lot of unused horizontal space in the chart. Perhaps the vertical text should be scaled if it exceeds a maximum length. Also, the legend panel (and other panel) are cut by a blue bar now.

AshrafSharf commented 9 years ago

TextNodes are scaled based on String length. Same rule is applied for Chart,Legends and Control Panels. Tested by duplicating the labels through string.js

image

samreid commented 9 years ago

Thanks @AshrafSharf, this looks much better. In the future, @jbphet & @samreid may make the Show and Legend panels the same width, and make the fonts the same size (even if it means shrinking all of them within a context equally).