phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

MembraneTraversalMotionStrategy is pretty useless, let's eliminate it #39

Closed jbphet closed 9 years ago

jbphet commented 9 years ago

The only thing added by the MembraneTraversalMotionStrategy class is the default max velocity. I know this came from the Java code, but I think it had more in it initially and got gradually eroded as the sim evolved. Now it seems like an unnecessary and unhelpful level of inheritance. Let's move the default max velocity to the shared constants and do away with this file.

Found during code review, see #29.

jbphet commented 9 years ago

Looks good, thanks. Closing.