Charges and concentrations are not being updated in playback mode

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 3 forks source link

Charges and concentrations are not being updated in playback mode #59

Closed jbphet closed 9 years ago

jbphet commented 9 years ago

The charge and concentration values are not updated when doing playback. They definitely are in the Java version, so this appears to have been introduced during the port. This can be duplicated on version http://www.colorado.edu/physics/phet/dev/html/neuron/1.0.0-dev.8/neuron_en.html.

AshrafSharf commented 9 years ago

I can see the values being updated to concentration values and to "charges symbol" during playback. @jbphet would like to discuss it today

jbphet commented 9 years ago

@AshrafSharf and I met via Skype and were able to duplicate the issue. It seems to only occur if the recording is made with concentrations hidden, then replayed with the concentrations visible.

AshrafSharf commented 9 years ago

NeuronModel's step was checking for concentrationReadout visibility before updating concentration values. This condition is now removed. I have tested the sim with dependencies pulled using checkout-shas

jbphet commented 9 years ago

Behavior now looks correct. Thanks. Closing.