search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Identify stable SHAs and add a dependencies.json file to the master branch (for now) #61

Closed jbphet closed 9 years ago

jbphet commented 9 years ago

Neuron depends on WebGL and is thus incompatible with the current version of Scenery 0.2. The original plan to deal with this was to use the 0.1 branches for Scenery and Joist, but this hasn't worked out, since other libraries are now becoming dependent upon Scenery 0.2 (for instance, Sun has added a dependency on AriaSpeech, which isn't present in Scenery 0.1). I discussed this with @samreid, and tried to stub AriaSpeech in Scenery and quickly started going down a rat hole, so we've decided to instead identify a set of SHAs that work for Neuron and maintain these in a dependencies.json file on the master branch until the RC branch is created, and do all development between now and then using the lib versions identified by these SHAs. Kind of a pain, but I think we're stuck with it.

jbphet commented 9 years ago

@AshrafSharf added a set of dependencies in this commit: https://github.com/phetsims/neuron/commit/ff17457a13e96e3cf1ac9f0cf211efea60c64cc4. I'm not sure exactly where these came from - the are close to the most recent dev version (dev.8) but not an exact match. I'll ask @AshrafSharf and will test them out in the mean time.

jbphet commented 9 years ago

We have something that now works, but it required modifying some project files that had been changed due to some phet-wide changes. We will need to add these changes back after branching, see #62.

jbphet commented 9 years ago

This issue should be kept open and any changes to the dependency file should be logged against it until the 1.0 branch is created.

jbphet commented 9 years ago

Due to work done for https://github.com/phetsims/neuron/issues/65, this sim is no longer incompatible with the master versions of the libraries, so support for its previous "semi-branched" state is no longer needed and have been reversed.