search

phetsims / neuron

"Neuron" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Membrane channel gates are not always reset when Reset All is pressed #89

Closed jbphet closed 8 years ago

jbphet commented 9 years ago

If the Reset All button is pressed when the dynamic sodium and/or potassium membrane channels are open, they are not always properly reset. This issue is visible on the current master and the most recent dev release, which is http://www.colorado.edu/physics/phet/dev/html/neuron/1.0.0-dev.13/neuron_en.html. It is probably present on other dev versions too, but hasn't been tested.

orejolaphet commented 9 years ago

I went through the dev versions. This issue has been present since http://www.colorado.edu/physics/phet/dev/html/neuron/1.0.0-dev.3/neuron_en.html

screen shot 2015-10-13 at 10 17 10 am

Screenshot from http://www.colorado.edu/physics/phet/dev/html/neuron/1.0.0-dev.13/neuron_en.html

screen shot 2015-10-13 at 10 13 04 am
jbphet commented 8 years ago

There were actually two problems that were causing this behavior. The first was that the reset of the membrane channels wasn't being conveyed to the view in some circumstances, so the view wasn't being updated. The second was that the DelayBuffer had a subtle bug that would cause it to provide old data after being cleared. Both of these issues have been addressed. Closing.