search

phetsims / normal-modes

"Normal Modes" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

convert from inherit to class #21

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

Related to #2 (code review):

  • [x] Use class and extends for defining classes and implementing inheritance. PHET_CORE/inherit was a pre-ES6 implementation of inheritance that is specific to PhET and has been supplanted by class and extends. inherit should not be used in new code.

The following types are defined using inherit, and should be converted to class.

ModeGraphCanvasNode StaticModeGraphCanvasNode

Hyodar commented 4 years ago

Converted from inherit to class in ModeGraphCanvasNode and StaticModeGraphCanvasNode.

Hyodar commented 4 years ago

Also, did d9d75db to follow the es6 class constructor tag pattern.

Hyodar commented 4 years ago

It seems OK, so I'll close it. If necessary, it can be opened again.