Closed pixelzoom closed 4 years ago
Related to #2 (code review).
There are a number of reset methods that do nothing, and are not called anywhere.
reset
For example, AmpPhaseAccordionBox.js:
/** * @public */ reset() { // NO-OP }
This isn't hurting anything. But in cases where reset (or some other method) does nothing, PhET typically does not implement the method.
Removed both reset and step methods that did nothing.
Following the issues workflow: Assigning @pixelzoom for review.
👍 closing.
Related to #2 (code review).
There are a number of
reset
methods that do nothing, and are not called anywhere.For example, AmpPhaseAccordionBox.js:
This isn't hurting anything. But in cases where
reset
(or some other method) does nothing, PhET typically does not implement the method.