phetsims / normal-modes

"Normal Modes" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

remove reset methods that do nothing? #43

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

Related to #2 (code review).

There are a number of reset methods that do nothing, and are not called anywhere.

For example, AmpPhaseAccordionBox.js:

    /**
     * @public
     */
    reset() {
      // NO-OP
    }

This isn't hurting anything. But in cases where reset (or some other method) does nothing, PhET typically does not implement the method.

Hyodar commented 4 years ago

Removed both reset and step methods that did nothing.

Hyodar commented 4 years ago

Following the issues workflow: Assigning @pixelzoom for review.

pixelzoom commented 4 years ago

👍 closing.