phetsims / normal-modes

"Normal Modes" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

'Reset All' does not reopen accordion boxes #72

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 12.0.1

Browser Safari

Problem description https://github.com/phetsims/qa/issues/724

If you close any of the accordion boxes on either screen, pressing 'Reset All' button does not reopen them.

Steps to reproduce

  1. Close any of the accordion boxes on either screen
  2. Press the reset button

Visuals panels

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Normal Modes‬ URL: https://phet-dev.colorado.edu/html/normal-modes/1.0.0-dev.5/phet/normal-modes_en_phet.html Version: 1.0.0-dev.5 2021-11-01 21:43:06 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Safari/605.1.15 Language: en-US Window: 1199x701 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
pixelzoom commented 2 years ago

Thanks @Nancy-Salpepi, reproduced. I've adjusted the title and report to indicate "accordion box". Panels do not expand/collapse.

pixelzoom commented 2 years ago

Inspecting the code, I see that none of the accordion boxes are provided with option expandedProperty. So they create their own expandedProperty, which needs to be reset.

pixelzoom commented 2 years ago

Fixed in master in the above commit. Back to @Nancy-Salpepi for review. If it looks OK, please close.

Nancy-Salpepi commented 2 years ago

Looks good.