search

phetsims / normal-modes

"Normal Modes" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

Misleading names for "number of masses" #89

Open pixelzoom opened 1 year ago

pixelzoom commented 1 year ago

"Number of mass" seems to actually be the "number of masses per row". Confirm and rename these things:

In NormalModesConstants:

NUMBER_OF_MASSES_RANGE: NUMBER_OF_MASSES_RANGE, //TODO actually number of masses PER ROW

In NormalModesModel:

    // @public {Property.<number>} the current number of visible masses
    //TODO this is actually the number of masses per row. In the 'Two Dimensions' screen, the number of masses is this value squared. https://github.com/phetsims/tasks/issues/1129
    this.numberOfMassesProperty = new NumberProperty( options.numberOfMasses, {