search

phetsims / number-compare

"Number Compare" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

CT TODO should have an issue #11

Closed KatieWoe closed 1 year ago

KatieWoe commented 1 year ago 
number-compare : lint
Lint failed with status code 1:
Running "lint" task

/data/share/phet/continuous-testing/ct-snapshots/1673587535578/number-compare/js/compare/model/CompareModel.ts
21:36 error TODO should have an issue: TODO: Factor out base class with NumberPlayModel.js todo-should-have-issue

/data/share/phet/continuous-testing/ct-snapshots/1673587535578/number-compare/js/compare/view/BlockValuesNode.ts
24:5 error TODO should have an issue: TODO: Fix drawing so initial state can be setup and updated here todo-should-have-issue

/data/share/phet/continuous-testing/ct-snapshots/1673587535578/number-compare/js/number-compare-main.ts
30:5 error TODO should have an issue: TODO fill in credits, all of these fields are optional, see joist.CreditsNode todo-should-have-issue

✖ 3 problems (3 errors, 0 warnings)

Fatal error: Lint failed
Snapshot from 1/12/2023, 10:25:35 PM
pixelzoom commented 1 year ago

/data/share/phet/continuous-testing/ct-snapshots/1673587535578/number-compare/js/compare/model/CompareModel.ts 21:36 error TODO should have an issue: TODO: Factor out base class with NumberPlayModel.js todo-should-have-issue

I deleted this TODO. CompareModel and NumberPlayModel share only 2 fields, and 0 methods. It's not worth a base class.

pixelzoom commented 1 year ago

I added GitHub issues for the other 2 TODOs, and tested grunt lint. I also opened https://github.com/phetsims/number-suite-common/issues/28, since this seems to be a bigger problem.

Closing.