Closed pixelzoom closed 1 year ago
I took care of this in the above commit. @chrisklus please review. Close if OK.
Thanks @pixelzoom, commits look great. "isMoreThan"
also needed to be renamed in babel since that string was already published. But I double checked the commit history (in number-play-strings_en.json since it was originally published as part of Number Play), and the string value was changed to "{{greaterNumber}} is greater than {{smallerNumber}}"
before publication, so the translated values are correct, just the keys needed to be updated.
I think we are all set to close here.
From the CRC:
Inspecting number-compare-strings_en.json, these 2 strings keys should be changed to match their values. The keys should be "isGreaterThan" and "hearNumberSentence" respectively. @chrisklus do you agree?