search

phetsims / number-compare

"Number Compare" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

"Hear Number Sentence" preference control has bogus description #16

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

In Number Compare, the title for this Preference control has been customized, but the description is totally incorrect:

screenshot_2180
pixelzoom commented 1 year ago

Fixed in the above commits. @chrisklus please review.

In Number Play Preferences:

screenshot_2182

In Number Compare Preferences:

screenshot_2181

Note that I wasn't sure exactly what the description should be in Number Compare. Will "number sentence" make sense to the student? It seems kind of vague to me, but it's how the control is titled. And Number Play uses "total" in the control's title and description, so I used that same pattern for Number Compare. Feel free to change.

chrisklus commented 1 year ago

Thanks @pixelzoom, these changes look good.

Note that I wasn't sure exactly what the description should be in Number Compare. Will "number sentence" make sense to the student? It seems kind of vague to me, but it's how the control is titled.

In general, all of these preference controls seem potentially not understandable by kindergarteners since reading proficiency isn't a requirement for using the general sim. I think they will be more used by teachers and parents.

And Number Play uses "total" in the control's title and description, so I used that same pattern for Number Compare. Feel free to change.

That looks great to me, thanks.

I think we are all set to close here.