search

phetsims / number-compare

"Number Compare" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

MissingVoiceWarningButton missing #17

Closed chrisklus closed 1 year ago

chrisklus commented 1 year ago

MissingVoiceWarningButton is included in Number Play but missing in Number Compare. I should factor out a type that puts these into one control and then use that in NP and NC.

pixelzoom commented 1 year ago

I'll take this one. Will factor out a control that includes SpeechSynthesisButton and MissingVoiceWarningButton.

pixelzoom commented 1 year ago

In the above commit, I factored out SpeechSynthesisControl, and used it in both NumberPlayScreenView (Ten and Twenty screens) and CompareScreenView. Note the layout problem in the Compare screen, reported in https://github.com/phetsims/number-compare/issues/18 -- it was present before making this change.

@chrisklus please review, close if OK.

pixelzoom commented 1 year ago

Please ignore commits shown immediately above, https://github.com/phetsims/beers-law-lab/commit/fe5cc1fb104b24c55ccbb516ca64f59a371c7d2b and https://github.com/phetsims/phet-io-sim-specific/commit/7502a1ebe68577242d2c014bc5d93d75c68513e4. They were incorrectly associated with this issue.

chrisklus commented 1 year ago

Thanks @pixelzoom! Looks great. I simplified parameter typing in SpeechSynthesisButton above based on your commit in https://github.com/phetsims/number-suite-common/commit/4227ce76b284a23d0b6fd42101a3cf733359d3e1. Closing.