Remove 'Sounds' from preferences

phetsims / number-compare

"Number Compare" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 0 forks source link

Remove 'Sounds' from preferences #19

Closed amanda-phet closed 1 year ago

amanda-phet commented 1 year ago

Number Compare doesn't have any sounds (Number Play has game sounds). This part of the preferences dialog is unnecessary.

chrisklus commented 1 year ago

Done in the above commit. @amanda-phet should we just do this in Number Play too since we couldn't get the toggle to show for Sounds there? It's just so pointless to have without a toggle.

amanda-phet commented 1 year ago

@chrisklus and I discussed and decided to remove this text in Number Compare (since there are no sounds) and leave it in Number Play. Both options look pretty terrible (and are even a bit confusing), but this option at least make some sense.