Pixel polishes - Githubissues

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 3 forks source link

Pixel polishes #21

Closed amanda-phet closed 3 years ago

amanda-phet commented 3 years ago

[x] match checkboxes to what we're using in other NL sims
[x] Make distance description larger and with more spacing under the accordion box
[x] Make the legend (lower lefthand corner) have larger circles, letters, and artwork

SaurabhTotey commented 3 years ago

I was using the NLCheckbox from NLC, but I realized that I wasn't using NLCheckboxGroup, so I have now switched NLD over to using that so that these checkboxes should match what is being done in the other NL sims. I still need to adjust the distance description: it is currently so far up because the generic number line, when vertical, takes up most of the vertical space. I intend to reduce the height of the vertical number line to give more space to the distance description. I also still need to adjust the legend.

SaurabhTotey commented 3 years ago

The distance description is now larger and has been moved down. I had to move down the vertical number line even more and also move down the elevation bounds so that the distance description has space. I still need to adjust the legend at the bottom left.

SaurabhTotey commented 3 years ago

I have now made adjustments to all the legend items in the swap area at the bottom left.

I have made changes to address all of the items in this issue, so I will assign to @amanda-phet to review.

amanda-phet commented 3 years ago

All looks good to me!