Closed SaurabhTotey closed 3 years ago
As of code review https://github.com/phetsims/number-line-distance/issues/35, the credits are completed empty. It would be good to take a stab at filling these in before the first dev test. At this point in the development, you should know everything except QA credits.
Hey @amanda-phet, an RC was recently created with an attempt at filling out credits. Do these credits look good to you?
When asked about credits for graphic arts, @amanda-phet said (over Slack):
Mariah Hermsmeyer, Megan Lai, Amanda McGarry
When asked about other designers, she said:
Kathy Perkins, Ian Whitacre
The credits should be complete, I would just like them to be verified.
When asked about credits for graphic arts, @amanda-phet said (over Slack):
Mariah Hermsmeyer, Megan Lai, Amanda McGarry
When asked about other designers, she said:
Kathy Perkins, Ian Whitacre
Based on this comment, Amanda should be included in the graphic arts credits and she is currently not.
I didn't put Amanda in the graphic arts section because she is already in the lead design section. @jbphet told me not to duplicate the name in both sections, but I asked in slack to make sure, where @pixelzoom replied "The policy is indeed no duplication. There’s no need to put Amanda in graphicArts." As such, I will close this issue, but please reopen if there are any other issues with credits.
Reopening because @pixelzoom pointed out that this issue should stay open until the sim is published as QA credits may change.
I believe QA credits are fine for this
Standard code review issue created for #35. Should be addressed before publication.