search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Should variable names and subscripts be translatable? #4

Closed SaurabhTotey closed 4 years ago

SaurabhTotey commented 4 years ago

Here are two screenshots from NLD that show variables. swap distancedescription As of this issue, these strings are translatable, but @jbphet is pointing out that we don't always allow translation of these because the translator can mess things up, and translators rarely, if ever, do translate variable names in other simulations when they are translatable. Should these strings be translatable in this simulation?

amanda-phet commented 4 years ago

Yes the variables should be translatable, but I'm not sure about the subscripts because I don't think we usually allow numerals to be translated. A few locales have translated variables (Greek is one).

These strings should also be translatable.

SaurabhTotey commented 4 years ago

Alright, currently the variables are translatable but they have the subscript formatting baggage with them. I'll make only the variable letters be translatable and make the subscript formatting with numerals happen in the code and remove those from the translation string.

amanda-phet commented 4 years ago

I see. I am not sure what we have done in the past with subscripts.. or if we've ever done something. Maybe check Graphing Lines (the Arabic translation, for example) and see what was done there.

ariel-phet commented 4 years ago

Looks like the Arabic translation leaves the subscripts alone, and it is not an issue. I agree with leaving the subscripts (which are numerals) non-translatable.

SaurabhTotey commented 4 years ago

In my latest commit, I made the subscripts not translatable, but left the variables to still be translatable. I closed this issue, but if further work needs to be done, please reopen!