search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Dropping an object near the number line sometimes results in incorrectly aligned object and dot #41

Closed amanda-phet closed 3 years ago

amanda-phet commented 3 years ago

Related to https://github.com/phetsims/number-line-distance/issues/34

When I drop an object in this new expanded region (ie, not directly in the final play area), the dot on the number line is often not right where it should be. I do not notice this in the house scene, only in the temperature and bird scenes.

Here's an example: image

I dropped the bird near the number line (not in the sky) and the sim detected that the closest location is 20. The bird flies over to the sky, and the dot says 20, but the dot is clearly not in the correct spot on the number line. If I click the bird once, the bird shifts to the integer location, and the dot realigns itself.

image

I am thinking the model needs to pick an integer value and location, so that the objects lands at the correct spot and the dot is in the right spot.

SaurabhTotey commented 3 years ago

This was a subtle bug, but I believe the latest commits should now have fixed this. Assigning to @amanda-phet to review.

amanda-phet commented 3 years ago

This looks fixed to me. Thanks!