Closed pixelzoom closed 3 years ago
Same problem in NLDBaseView.js:
Property.multilink(
[
model.distanceRepresentationProperty,
model.numberLine.orientationProperty,
model.isPrimaryControllerSwappedProperty,
model.pointValuesProperty
],
( distanceRepresentation, orientation, isPrimaryNodeSwapped, pointValues ) => {
I fixed the names, so I will close this issue.
For code review #35.
In miltilinks, parameter names in the observer function should match the names of the dependencies.
In DistanceShadedNumberLineNode.js
Parameter
isPrimaryNodeSwapped
doesn't match dependencymodel.isPrimaryControllerSwappedProperty
. Consider renaming toisPrimaryControllerSwapped
.