Closed pixelzoom closed 3 years ago
I made an NLDSceneView as suggested here, but I made the superclass create the NLDBaseView
and the DistanceShadedNumberLineNode
. I will close this issue, but feel free to reopen if there is more work to be done.
👍🏻 This looks very nice.
For code review #35.
There's a bit of dupliction in DistanceSceneView, ElevationSceneView, and TemperatureSceneView. You might consider factoring the commonalities out into a NLDSceneView base class.
The bits that they have in common are:
this.baseView
numberLineNode
pointControllerNodeLayer
reset
methods are identical.Or maybe the base class is as simple as this: