search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

LoL no longer pauses fully #65

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/qa/issues/683. Connected to https://github.com/phetsims/special-ops/issues/182, in which the sim did not appear properly paused. However, now items are interactable during this pause. This was seen with the Legends of Learning harness on 8/4/21. @kathy-phet if this is a harness issue we may need to contact Legends of Learning again. notpausedlol

jbphet commented 3 years ago

This doesn't appear to be a sim-specific issue, and there is already a general issue for the problem, see https://github.com/phetsims/special-ops/issues/182. In that issue @kathy-phet says that it shouldn't block publication, and also that she'd contacted LoL and will report back.

Because this is not sim-specific, isn't blocking, and is being tracked elsewhere, I'm going to close this issue.

amanda-phet commented 3 years ago

Is this sim-specific, or related to the lol harness? Seems like it is a LoL issue, so I think this should be resolved over in https://github.com/phetsims/special-ops/issues/182 and not block this sim from being published.

kathy-phet commented 3 years ago

This behavior has changed on master. The sim should obey the pause command. This appears to be a common code change in the way the sim responds to the LOL harness.

KatieWoe commented 3 years ago

Ok, very odd new behavior. I went to check published sims to see how far back this might have been introduced. However, the brand-new NLD sim that showed the issue in rc does not seem to show it in the published version.

kathy-phet commented 3 years ago

Just a misspelling of the query parameter in the first test. Closing.