Closed amanda-phet closed 9 months ago
We often both, in cases like this. So its in the preferences, but initial selection can be controlled by query parameter.
Thanks @kathy-phet . Should we try to re-publish the sim soon with this feature? Or wait until there's another reason to re-publish?
Sorry I didn't reply earlier. Yes, it would be nice to republish with this feature when QA has a lull. (Came up because there is a physics talk that could use this feature today.)
I think this is the perfect time to include this feature! Assigning to me and @Luisav1 for whoever can get to it first.
Discussed with @amanda-phet we will use a query parameter flag displacement
. This will replace the text "Directed Distance" with "Displacement".
Is this becoming a sim-specific setting in Preferences dialog?
When talking with @amanda-phet it sounded like we were only doing it as a query parameter, not a sim-specific preference.
@kathy-phet would you like it to be added to Preferences? I'm not sure how involved that is, but @marlitas can probably weigh in.
It's not that involved. I would assume we just want that to be a toggle control.
@marlitas and I discussed and would like this in the Simulation tab of the preferences dialog. I think a radio button is more appropriate since it's really a choice of two different labels, not a toggle where we are turning something "on."
It can look something like this:
Control label: Terminology Options:
This was done in the above commit. Over to @amanda-phet for design review!
Looks good. I'd like to add a description to this preference. Can you include this description: Choose the terminology used to describe the difference between two integers.
@amanda-phet, the description has been added. Let me know what you think, and close if all looks well.
Looks good. Thanks!
A physics teacher on twitter recommended the change to "displacement", and Ariel suggested we add this an an option behind a query parameter. I'm wondering if we would want it to be a query parameter, or instead maybe an option in the preferences menu. Assinging to @kathy-phet to discuss.