search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Rename "directed distance" behind a query parameter #68

Closed amanda-phet closed 9 months ago

amanda-phet commented 3 years ago

A physics teacher on twitter recommended the change to "displacement", and Ariel suggested we add this an an option behind a query parameter. I'm wondering if we would want it to be a query parameter, or instead maybe an option in the preferences menu. Assinging to @kathy-phet to discuss.

kathy-phet commented 3 years ago

We often both, in cases like this. So its in the preferences, but initial selection can be controlled by query parameter.

amanda-phet commented 3 years ago

Thanks @kathy-phet . Should we try to re-publish the sim soon with this feature? Or wait until there's another reason to re-publish?

kathy-phet commented 2 years ago

Sorry I didn't reply earlier. Yes, it would be nice to republish with this feature when QA has a lull. (Came up because there is a physics talk that could use this feature today.)

marlitas commented 10 months ago

I think this is the perfect time to include this feature! Assigning to me and @Luisav1 for whoever can get to it first.

marlitas commented 10 months ago

Discussed with @amanda-phet we will use a query parameter flag displacement. This will replace the text "Directed Distance" with "Displacement".

kathy-phet commented 10 months ago

Is this becoming a sim-specific setting in Preferences dialog?

marlitas commented 10 months ago

When talking with @amanda-phet it sounded like we were only doing it as a query parameter, not a sim-specific preference.

amanda-phet commented 9 months ago

@kathy-phet would you like it to be added to Preferences? I'm not sure how involved that is, but @marlitas can probably weigh in.

marlitas commented 9 months ago

It's not that involved. I would assume we just want that to be a toggle control.

amanda-phet commented 9 months ago

@marlitas and I discussed and would like this in the Simulation tab of the preferences dialog. I think a radio button is more appropriate since it's really a choice of two different labels, not a toggle where we are turning something "on."

It can look something like this: image

Control label: Terminology Options:

marlitas commented 9 months ago

This was done in the above commit. Over to @amanda-phet for design review!

amanda-phet commented 9 months ago

Looks good. I'd like to add a description to this preference. Can you include this description: Choose the terminology used to describe the difference between two integers.

marlitas commented 9 months ago

@amanda-phet, the description has been added. Let me know what you think, and close if all looks well.

amanda-phet commented 9 months ago

Looks good. Thanks!