search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Memory Leak #79

Closed KatieWoe closed 11 months ago

KatieWoe commented 11 months ago

The memory test for https://github.com/phetsims/qa/issues/1005 on Win 11 Chrome at 1 min intervals seems to indicate a memory leak. memry

marlitas commented 11 months ago

I believe I addressed the culprits of the leak in the above commit. I would like a review by another dev on one of the disposal strategies, I'm not sure if I handled it in the best way.

Over to @KatieWoe to confirm the leak is fixed on main. Please leave open either way so I can consult with another dev on the changes.

marlitas commented 11 months ago

@mattpen helped me look through the code changes and provided some great insight that cleaned things up. @KatieWoe this is ready to close if all looks good on your end.

KatieWoe commented 11 months ago

Memory test looks much better now. newmem