phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Touch areas for checkboxes don't dynamically update #81

Closed Nancy-Salpepi closed 9 months ago

Nancy-Salpepi commented 9 months ago

Test device MacBook Air M1 chip

Operating System 14.1.1

Browser Safari 17.1

Problem description For https://github.com/phetsims/qa/issues/1005, the pointer areas for the checkboxes update when I change locale but the touch areas do not.

Steps to reproduce

  1. Add ?showPointerAreas
  2. Switch locales

Visuals Here is English vs. French:

Screenshot 2023-11-27 at 8 31 29 AM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Recta Numérica: Distancia‬ URL: https://phet-dev.colorado.edu/html/number-line-distance/1.1.0-dev.2/phet/number-line-distance_all_phet.html?showPointerAreas Version: 1.1.0-dev.2 2023-11-20 22:12:27 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.1 Safari/605.1.15 Language: en-US Window: 1282x709 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
marlitas commented 9 months ago

This should be fixed in the above commit. Over to @Nancy-Salpepi to check on main. Close if all looks well!

Nancy-Salpepi commented 9 months ago

Looks good on main!