phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Points off Scale panel can be offscreen in some locales #83

Closed Nancy-Salpepi closed 11 months ago

Nancy-Salpepi commented 11 months ago

Test device MacBook Air M1 chip/Dell

Operating System 14.1.1/Win10

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/1005, I noticed that the "Points off Scale!" string wasn't translated in 1.1.0-dev.2. On main, that problem seems to be fixed, but the panel on the right side no longer aligns with the right edge of the number line. This causes the panel to sometimes be cut off with certain locales and smaller screen sizes.

Steps to reproduce Here is an example:

  1. In main, change the locale to Slovencina.
  2. On the Generic screen, place a ball on the number line
  3. Increase the ball's value until the "Points off Scale!" statement appears.

Visuals on Main:

Screenshot 2023-11-27 at 3 21 50 PM

Published:

Screenshot 2023-11-27 at 3 21 37 PM

On main with the iPad:

Screenshot 2023-11-27 at 3 24 09 PM
marlitas commented 11 months ago

I'm having a hard time recreating this. I followed the steps and the statement appears to be lined up with the number line as expected. Perhaps I hit this in some other commit somehow, but that seems unlikely to me...

image

@Nancy-Salpepi can you confirm you're still seeing this on your end?

Nancy-Salpepi commented 11 months ago

@marlitas it does happen. Sorry....my order of steps isn't right. Change the locale last:

  1. In main, on the Generic screen, place a ball on the number line
  2. Increase the ball's value until the "Points off Scale!" statement appears.
  3. Change the locale to Slovencina.
marlitas commented 11 months ago

That did the trick! Thanks @Nancy-Salpepi. This is now ready to check on main. Feel free to close if all looks well.

Nancy-Salpepi commented 11 months ago

Looks good @marlitas!!