search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Panning is buggy #87

Closed marlitas closed 8 months ago

marlitas commented 8 months ago

Originally found in Number Line Operations: https://github.com/phetsims/number-line-operations/issues/108

NLD will need a fix for it's specific use case as well.

jessegreenberg commented 8 months ago

I think this is fixed by a commit in number-line-common: https://github.com/phetsims/number-line-common/commit/3c5c9aaae87ae0ce90081685eb6d32e38de9b9a2

Tracked in https://github.com/phetsims/number-line-integers/issues/128, but leaving this issue open since a cherry-pick might be needed for this sim's release SHAs.

marlitas commented 8 months ago

This was cherry-picked for https://github.com/phetsims/qa/issues/1018. Feel free to close if all looks well.

Nancy-Salpepi commented 8 months ago

This is fixed on main but not fixed in rc.4.

marlitas commented 8 months ago

I must have missed a commit in the RC cherry-picks... checking

Nancy-Salpepi commented 8 months ago

Looks good in rc. 5!