search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Mid-project code review #9

Closed jbphet closed 3 years ago

jbphet commented 4 years ago

I need to take a fairly detailed pass through the code and provide feedback on it. I've been busy on other priorities for quite a while, and this code hasn't gotten as much scrutiny as I probably should be giving it.

@SaurabhTotey is unlikely to have much time for this sim until the end of the year, so I should try to get it done before then. I'm going to mark it as deferred and will set up a calendar reminder to get to it.

jbphet commented 3 years ago

The mid-project review is complete. It's coming along well. Assigning to @SaurabhTotey to follow up on the REVIEW comments. Several issues have also been logged, but they are pretty standalone, so this can be closed once all the comments have been addressed.

SaurabhTotey commented 3 years ago

All the REVIEW comments have been addressed, so I am closing this issue. #11, #13, and #15 are still outstanding.