phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

negative sign appears in absolute value statement #115

Closed Nancy-Salpepi closed 10 months ago

Nancy-Salpepi commented 10 months ago

Test device MacBook Air M1 chip and Dell

Operating System macOS 14.0 and Win10

Browser Safari 17 and Chrome

Problem description For https://github.com/phetsims/qa/issues/1002, the negative sign still appears for the absolute value in the Elevation Scene

Steps to reproduce

  1. In the Elevation Scene, check Absolute Value
  2. Add character, fish and bird to the water (so the actual value is negative) --the absolute value should be positive

Visuals Dev version:

Screenshot 2023-11-14 at 8 31 43 AM

Published:

Screenshot 2023-11-14 at 8 44 07 AM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Line: Integers‬ URL: https://phet-dev.colorado.edu/html/number-line-integers/1.2.0-dev.5/phet/number-line-integers_all_phet.html Version: 1.2.0-dev.5 2023-11-13 16:44:44 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36 Language: en-US Window: 1386x728 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
marlitas commented 10 months ago

This should now be solved with the above commit. @Nancy-Salpepi can you confirm it looks good on main?

Nancy-Salpepi commented 10 months ago

This looks fixed now on main, but not sure if I should close because of https://github.com/phetsims/number-line-integers/issues/114.

marlitas commented 10 months ago

I think this is separate from #114 Thanks for checking in on that though. Closing :-)