search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Absolute value statement layout wonky in Elevation scene #117

Closed marlitas closed 10 months ago

marlitas commented 10 months ago

While working on https://github.com/phetsims/number-line-integers/issues/115 I noticed the layout of the absoluteValue label looked wonky in the elevation scene. The label was not adjusting it's width dynamically, and it was slightly overlapping the swimming character.

marlitas commented 10 months ago

I think this is fixed now. Over to @amanda-phet to double check that the absolute value labels are looking good in the Explore Screen, elevation scene.

amanda-phet commented 10 months ago

Something is definitely not right...

image
marlitas commented 10 months ago

Haha yeah... I don't know what happened there. Fixed in https://github.com/phetsims/number-line-integers/issues/114, should be ready to check now.

amanda-phet commented 10 months ago

These look good to me! I like the rounded corners, much more current with how we do these labels now. The only thing I see is that I'd like a little more transparency/less opacity. It doesn't need to match the old one, but just go down .1 or .2. Super minor. (ex if they are currently .95 go down to .93)

image image
marlitas commented 10 months ago

Here it is we the new opacity:

image

If that looks good, feel free to close!

amanda-phet commented 10 months ago

Looks good, thanks!