search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

currency no longer centered on coin #127

Closed Nancy-Salpepi closed 10 months ago

Nancy-Salpepi commented 11 months ago

Test device MacBook Air M1 chip

Operating System 14.1.2

Browser chrome

Problem description For https://github.com/phetsims/qa/issues/1016, when the currency is longer than 1-2 characters, it is no longer centered. On published it is centered.

Visuals Ex: Turkman: RC:

Screenshot 2023-12-19 at 12 47 10 PM

Published:

Screenshot 2023-12-19 at 12 48 58 PM

Ex: Oromo RC:

Screenshot 2023-12-19 at 12 44 54 PM

Published:

Screenshot 2023-12-19 at 12 45 19 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Sarara Lakkoofsaa: Lakkoofsota guutuu‬ URL: https://phet-dev.colorado.edu/html/number-line-integers/1.2.0-rc.3/phet/number-line-integers_all_phet.html Version: 1.2.0-rc.3 2023-12-13 17:13:14 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36 Language: en-US Window: 1429x728 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
marlitas commented 11 months ago

Fixed above. Ready to cherry pick.

Nancy-Salpepi commented 10 months ago

looks good in rc.4. Closing.