search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Drag listener for object should be interrupted when trying to change value #129

Open Nancy-Salpepi opened 11 months ago

Nancy-Salpepi commented 11 months ago

Test device iPad

Operating System 17.0.2

Browser safari

Problem description For https://github.com/phetsims/qa/issues/1016 and similar to https://github.com/phetsims/number-line-operations/issues/114, in the first and second scenes of the Explore Screen, if I hold down the person/bird/fish/money jar with one finger while changing the value with another, the object returns to its original position.

I'll let you decide whether to defer or not @marlitas.

Steps to reproduce

  1. In the first scene, add the bird and hold it there with one finger
  2. With a second finger move the sphere along the number line to change the value. Remove that finger.
  3. Lift your first finger off the screen--bird returns to original spot
  4. Switch to the second scene and hold down the money jar with one finger while pressing the Add Coins button with another.
  5. Lift your finger off the Add Coins button.

Visuals

https://github.com/phetsims/number-line-integers/assets/87318828/46e4c4e0-f7e9-482b-8b66-9051accc5614

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Line: Integers‬ URL: https://phet-dev.colorado.edu/html/number-line-integers/1.2.0-rc.3/phet/number-line-integers_all_phet.html Version: 1.2.0-rc.3 2023-12-13 17:13:14 UTC Features missing: applicationcache, applicationcache Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15 Language: en-US Window: 810x977 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
marlitas commented 11 months ago

My recommendation is to defer here. The sphere on the number-line is very intertwined with the node in the nature scene and a simple interruptSubtreeInput will not work here. I believe this is outside the scope of this RC at this point.

@amanda-phet?

amanda-phet commented 11 months ago

I'm ok with deferring this