search

phetsims / number-line-integers

"Number Line: Integers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 4 forks source link

Use equal sign when comparing two equal values #130

Closed amanda-phet closed 9 months ago

amanda-phet commented 9 months ago

@Nancy-Salpepi was testing the sim and thought it was odd to see a statement like 0 ≤ 0. While it's not technically an incorrect statement, it makes you wonder why not just write 0 = 0. I am OK with this behavior when two objects/points temporarily occupy the same spot, until you drop the object and see something like 0 < 1, but not when there is no interaction happening. When you have only one point/object, I can't see a good reason for displaying 0 ≤ 0. image

We need the original behavior when there are three points/objects (it would be really odd to see 0 = 0 < 1 in math and we don't want to encourage that). However, with only two, or one, an equal sign is perfect.

I discussed this with @catherinecarter and @kathy-phet as well, and @marlitas found a non-intrusive way to make this change in the code.

marlitas commented 9 months ago

Committed above. Ready for cherry-pick

Nancy-Salpepi commented 9 months ago

This new change looks great!

When testing I noticed that in the Temperature scene, after the temperature of a thermometer changes so as not to be equal to another one, clicking on that thermometer, changes it back to the 'equal value'. This behavior is also seen in published, but doesn't occur in the other two scenes. Don't know if it's worth the time to fix this, but wanted to mention. Feel free to ignore and close!

https://github.com/phetsims/number-line-integers/assets/87318828/34ddf71a-5eea-4e01-8073-b6906320120a

marlitas commented 9 months ago

Hmmm. It seems that clicking on the thermometer is causing enough movement to change the temperature a bit, which doesn't seem all that buggy to me. I think it's fine, especially since we see it in published. Thanks @Nancy-Salpepi! Closing.